Remove aws-xray-sdk #171
Merged
Remove aws-xray-sdk #171
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxday
force-pushed
the
maxday/remove-xray-sdk
branch
from
8da73fe to
b3b8a35
Compare
maxday
commented
Sep 3, 2021
| flake8,gitlab.com/pycqa/flake8,MIT,"Copyright (C) 2011-2013 Tarek Ziade <[email protected]>. Copyright (C) 2012-2016 Ian Cordasco <[email protected]>." | ||
| nose2,github.com/nose-devs/nose2,BSD-2-Clause,"Copyright (c) 2012, Jason Pellerin. All rights reserved." | ||
| requests,github.com/kennethreitz/requests,Apache-2.0,"Copyright 2018 Kenneth Reitz" |
There was a problem hiding this comment.
requests was previously removed
DarcyRaynerDD
approved these changes
Sep 9, 2021
| "trace_id": context["trace_id"], | ||
| "parent_id": context["parent_id"], | ||
| "name": XraySubsegment.NAME, | ||
| "start_time": time.time(), |
There was a problem hiding this comment.
Just want to verify that time.time() returns in the correct unit: https://docs.aws.amazon.com/xray/latest/devguide/xray-api-sendingdata.html . I believe there might be a bug in the node version where this timestamp is off by an order of magnitude.
There was a problem hiding this comment.
I've checked at https://github.com/aws/aws-xray-sdk-python/blob/894b419518e14b5cb2a75293ed4da17f87b2a7c0/aws_xray_sdk/core/models/entity.py#L39 and it seems correct?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
aws-xray-sdkfrom the layerMotivation
Cold start performance improvements
Testing Guidelines
Unit tests + integration tests + manual test
Additional Notes
Types of Changes
Check all that apply