-
Notifications
You must be signed in to change notification settings - Fork 45
Extract span tags from triggering event #101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 12 commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
2f051a6
add trigger event span tags
DylanLovesCoffee d6fbf3e
add tests and sample events
DylanLovesCoffee ce92c3f
Merge branch 'master' into dylan/trigger-tags
DylanLovesCoffee 64fb4ec
update snapshots
DylanLovesCoffee 080f007
lint
DylanLovesCoffee 1d611c0
implement feedback
DylanLovesCoffee d83ee4e
refactor adding tags
DylanLovesCoffee b840c3d
black
DylanLovesCoffee d731561
include alb for http tags
DylanLovesCoffee 15c4610
add s3 test
DylanLovesCoffee ec51ccd
nits and add CN and Gov arn regions
DylanLovesCoffee f275936
always add trigger tags to xray subseg
DylanLovesCoffee 9cfaedc
implement feedback
DylanLovesCoffee 1965908
handle Lambda response status code
DylanLovesCoffee e680aff
renaming for specificity
DylanLovesCoffee c0bc254
carry response status_code to xray
DylanLovesCoffee eaa952d
cleanup
DylanLovesCoffee 195a6aa
fix merge conflicts
DylanLovesCoffee 369bdfc
add xray dummy subsegment for trigger tags at end of invocation
DylanLovesCoffee 79140cf
rename trigger tag and update snapshots
DylanLovesCoffee a02c289
lint EOF extra line
DylanLovesCoffee a9bbf0c
update with feedback
DylanLovesCoffee 5375952
Merge branch 'main' into dylan/trigger-tags
DylanLovesCoffee 0e71a7e
update snapshots
DylanLovesCoffee 20b4945
fix
DylanLovesCoffee 3190475
fix my fix
DylanLovesCoffee File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,205 @@ | ||
# Unless explicitly stated otherwise all files in this repository are licensed | ||
# under the Apache License Version 2.0. | ||
# This product includes software developed at Datadog (https://www.datadoghq.com/). | ||
# Copyright 2019 Datadog, Inc. | ||
|
||
import base64 | ||
import gzip | ||
import json | ||
from io import BytesIO, BufferedReader | ||
|
||
|
||
EVENT_SOURCES = [ | ||
"aws:dynamodb", | ||
"aws:kinesis", | ||
"aws:s3", | ||
"aws:sns", | ||
"aws:sqs", | ||
] | ||
|
||
GOVCLOUD_REGIONS = ["us-gov-east-1", "us-gov-west-1"] | ||
DylanLovesCoffee marked this conversation as resolved.
Show resolved
Hide resolved
|
||
CHINA_REGIONS = ["cn-north-1", "cn-northwest-1"] | ||
|
||
|
||
def get_arn_region_identifier(region): | ||
DylanLovesCoffee marked this conversation as resolved.
Show resolved
Hide resolved
|
||
if region in GOVCLOUD_REGIONS: | ||
return "aws-us-gov" | ||
if region in CHINA_REGIONS: | ||
return "aws-cn" | ||
return "aws" | ||
|
||
|
||
def get_first_record(event): | ||
records = event.get("Records") | ||
if records and len(records) > 0: | ||
return records[0] | ||
|
||
|
||
def get_event_source(event): | ||
DylanLovesCoffee marked this conversation as resolved.
Show resolved
Hide resolved
DylanLovesCoffee marked this conversation as resolved.
Show resolved
Hide resolved
|
||
"""Determines the source of the trigger event | ||
|
||
Possible Returns: | ||
api-gateway | application-load-balancer | cloudwatch-logs | | ||
cloudwatch-events | cloudfront | dynamodb | kinesis | s3 | sns | sqs | ||
""" | ||
event_source = event.get("eventSource") or event.get("EventSource") | ||
|
||
request_context = event.get("requestContext") | ||
if request_context and request_context.get("stage"): | ||
event_source = "api-gateway" | ||
|
||
if request_context and request_context.get("elb"): | ||
event_source = "application-load-balancer" | ||
|
||
if event.get("awslogs"): | ||
event_source = "cloudwatch-logs" | ||
|
||
event_detail = event.get("detail") | ||
cw_event_categories = event_detail and event_detail.get("EventCategories") | ||
if event.get("source") == "aws.events" or cw_event_categories: | ||
event_source = "cloudwatch-events" | ||
tianchu marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
event_record = get_first_record(event) | ||
if event_record: | ||
event_source = event_record.get("eventSource") or event_record.get( | ||
"EventSource" | ||
) | ||
if event_record.get("cf"): | ||
event_source = "cloudfront" | ||
|
||
if event_source in EVENT_SOURCES: | ||
event_source = event_source.replace("aws:", "") | ||
return event_source | ||
|
||
|
||
def parse_event_source_arn(source, event, context): | ||
""" | ||
Parses the trigger event for an available ARN. If an ARN field is not provided | ||
in the event we stitch it together. | ||
""" | ||
split_function_arn = context.invoked_function_arn.split(":") | ||
region = split_function_arn[3] | ||
account_id = split_function_arn[4] | ||
aws_arn = get_arn_region_identifier(region) | ||
|
||
event_record = get_first_record(event) | ||
# e.g. arn:aws:s3:::lambda-xyz123-abc890 | ||
if source == "s3": | ||
return event_record.get("s3")["bucket"]["arn"] | ||
|
||
# e.g. arn:aws:sns:us-east-1:123456789012:sns-lambda | ||
if source == "sns": | ||
return event_record.get("Sns")["TopicArn"] | ||
|
||
# e.g. arn:aws:cloudfront::123456789012:distribution/ABC123XYZ | ||
if source == "cloudfront": | ||
distribution_id = event_record.get("cf")["config"]["distributionId"] | ||
return "arn:{}:cloudfront::{}:distribution/{}".format( | ||
aws_arn, account_id, distribution_id | ||
) | ||
|
||
# e.g. arn:aws:apigateway:us-east-1::/restapis/xyz123/stages/default | ||
if source == "api-gateway": | ||
request_context = event.get("requestContext") | ||
return "arn:{}:apigateway:{}::/restapis/{}/stages/{}".format( | ||
aws_arn, region, request_context["apiId"], request_context["stage"] | ||
) | ||
|
||
# e.g. arn:aws:elasticloadbalancing:us-east-1:123456789012:targetgroup/lambda-xyz/123 | ||
if source == "application-load-balancer": | ||
request_context = event.get("requestContext") | ||
return request_context.get("elb")["targetGroupArn"] | ||
|
||
# e.g. arn:aws:logs:us-west-1:123456789012:log-group:/my-log-group-xyz | ||
if source == "cloudwatch-logs": | ||
with gzip.GzipFile( | ||
fileobj=BytesIO(base64.b64decode(event["awslogs"]["data"])) | ||
) as decompress_stream: | ||
data = b"".join(BufferedReader(decompress_stream)) | ||
logs = json.loads(data) | ||
log_group = logs.get("logGroup", "cloudwatch") | ||
return "arn:{}:logs:{}:{}:log-group:{}".format( | ||
aws_arn, region, account_id, log_group | ||
) | ||
|
||
# e.g. arn:aws:events:us-east-1:123456789012:rule/my-schedule | ||
if source == "cloudwatch-events" and event.get("resources"): | ||
return event.get("resources")[0] | ||
|
||
|
||
def get_event_source_arn(source, event, context): | ||
event_source_arn = event.get("eventSourceARN") or event.get("eventSourceArn") | ||
|
||
event_record = get_first_record(event) | ||
if event_record: | ||
event_source_arn = event_record.get("eventSourceARN") or event_record.get( | ||
"eventSourceArn" | ||
) | ||
|
||
if event_source_arn is None: | ||
event_source_arn = parse_event_source_arn(source, event, context) | ||
|
||
return event_source_arn | ||
|
||
|
||
def get_http_tags(event): | ||
DylanLovesCoffee marked this conversation as resolved.
Show resolved
Hide resolved
|
||
""" | ||
Extracts HTTP facet tags from the triggering event | ||
""" | ||
http_tags = {} | ||
request_context = event.get("requestContext") | ||
path = event.get("path") | ||
method = event.get("httpMethod") | ||
if request_context and request_context.get("stage"): | ||
if request_context.get("domainName"): | ||
http_tags["http.url"] = request_context["domainName"] | ||
|
||
path = request_context.get("path") | ||
method = request_context.get("httpMethod") | ||
# Version 2.0 HTTP API Gateway | ||
apigateway_v2_http = request_context.get("http") | ||
if event.get("version") == "2.0" and apigateway_v2_http: | ||
path = apigateway_v2_http.get("path") | ||
method = apigateway_v2_http.get("method") | ||
|
||
if path: | ||
http_tags["http.url_details.path"] = path | ||
if method: | ||
http_tags["http.method"] = method | ||
|
||
headers = event.get("headers") | ||
if headers and headers.get("Referer"): | ||
http_tags["http.referer"] = headers["Referer"] | ||
|
||
return http_tags | ||
|
||
|
||
def extract_trigger_tags(event, context): | ||
""" | ||
Parses the trigger event object to get tags to be added to the span metadata | ||
""" | ||
trigger_tags = {} | ||
event_source = get_event_source(event) | ||
if event_source: | ||
trigger_tags["trigger.event_source"] = event_source | ||
|
||
event_source_arn = get_event_source_arn(event_source, event, context) | ||
if event_source_arn: | ||
trigger_tags["trigger.event_source_arn"] = event_source_arn | ||
|
||
if event_source in ["api-gateway", "application-load-balancer"]: | ||
trigger_tags.update(get_http_tags(event)) | ||
|
||
return trigger_tags | ||
|
||
|
||
def set_http_status_code_tag(span, response): | ||
""" | ||
If the Lambda was triggered by API Gateway or ALB add the returned status code | ||
as a tag to the function execution span | ||
""" | ||
is_http_trigger = span and span.get_tag("trigger.event_source") == ( | ||
"api-gateway" or "application-load-balancer" | ||
) | ||
if is_http_trigger and response and response.get("statusCode"): | ||
span.set_tag("http.status_code", response.get("statusCode")) |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.