Extract span tags from triggering event #101
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tianchu
reviewed
Dec 9, 2020
tianchu
reviewed
Dec 9, 2020
tianchu
reviewed
Dec 9, 2020
tianchu
reviewed
Dec 9, 2020
tianchu
reviewed
Dec 9, 2020
tianchu
reviewed
Dec 9, 2020
11 tasks
tianchu
reviewed
Dec 22, 2020
tianchu
reviewed
Dec 23, 2020
tianchu
reviewed
Dec 23, 2020
tianchu
reviewed
Dec 23, 2020
tianchu
reviewed
Dec 23, 2020
tianchu
reviewed
Dec 23, 2020
tianchu
reviewed
Dec 23, 2020
tianchu
reviewed
Dec 23, 2020
datadog_lambda/wrapper.py
Outdated
| # Extract trigger tags and add them to a subsegment if found | ||
| trigger_tags = extract_trigger_tags(event, context) | ||
| if trigger_tags: | ||
| create_dd_root_span_metadata_subsegment(trigger_tags) |
There was a problem hiding this comment.
BTW, just a reminder, i recall you would have to duplicate the root span tags to the aws.lambda.function span as well, right?
tianchu
reviewed
Dec 28, 2020
tianchu
reviewed
Dec 28, 2020
tianchu
reviewed
Dec 28, 2020
DylanLovesCoffee
commented
Jan 4, 2021
DylanLovesCoffee
commented
Jan 4, 2021
tianchu
reviewed
Jan 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Parses the event invoking the function for tags to be added to the span. Currently only adds the following services to be detected: API Gateway, ALB, SQS, SNS, DynamoDB, Kinesis, Cloudfront, CW Logs, CW Events. API Gateway and ALB trigger events will also add the HTTP url, method, path, referer and status code response if available.
For the case of X-Ray <> Datadog hybrid tracing, we create an additional dummy Datadog subsegment for the trigger tags.
Motivation
SLS-790 - To give information on what triggered the function execution in one's traces.
Testing Guidelines
New unit test and edited an existing one. Updated snapshots.
Additional Notes
Types of Changes
Check all that apply