Add runtime and memorysize tags to enhanced metrics #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DarcyRaynerDD
approved these changes
Oct 30, 2019
| processVersionTagString = RuntimeTagValues.Node8; | ||
| } | ||
|
|
||
| if (processVersion.startsWith("v10")) { |
There was a problem hiding this comment.
Wondering if it might be useful to keep the minor version, since AWS seems to reserve the right to update it 🤔 . On one hand, it's more accurate and might reveal why a regression occurred, on the other it doesn't match the aws specified runtime.
Codecov Report
@@ Coverage Diff @@
## master #31 +/- ##
==========================================
+ Coverage 90.09% 90.78% +0.69%
==========================================
Files 21 22 +1
Lines 555 575 +20
Branches 88 92 +4
==========================================
+ Hits 500 522 +22
+ Misses 34 32 -2
Partials 21 21
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds
runtimeandmemorysizetags to enhanced invocations and errors metrics.Motivation
https://trello.com/c/DPjTvXFl/164-add-runtime-and-memorysize-tags-to-layer-enhanced-metrics
Testing Guidelines
Tested and confirmed to work on our demo functions