script -e: Keep temporaries around long enough to print them #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for cargo script -e, simply pass the block to println. This allows printing more expressions (those that borrow from temporaries that go out of scope at the end of the statement). For example, this makes cargo script -e '[1, 2, 3].iter().max()' compile.
|
I don't understand the testing setup to be honest. Trying to use |
|
So, I pulled it out of the |
|
We can write something more convoluted that preserves that: match <expr> {
x => println!("{:?}", x);
} |
|
Updated using a match, it should satisfy both the concerns. This places the expression to be evaluated outside of the macro. |
|
Rebased and merged in 850fae4. I have this nagging feeling there was a reason I put the value of the expression into a temporary, but I can't remember what it is, and this passes tests. So it can't have been that important. |
|
Yay! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For cargo script -e, simply pass the block to println. This allows
printing more expressions (those that borrow from temporaries that go
out of scope at the end of the statement).
For example, this makes cargo script -e '[1, 2, 3].iter().max()' compile.