Skip to content

fix: throws the full Error message when the Extension load exception #729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mortalYoung merged 1 commit into from
Apr 29, 2022
Merged

fix: throws the full Error message when the Extension load exception #729

mortalYoung merged 1 commit into from
Apr 29, 2022

Conversation

@wewoor
Copy link
Collaborator

@wewoor wewoor commented Apr 27, 2022

Description

Throws the full Error message when the Extension load exception

Fixes #710

Changes

  • Append the Exception object e in the ExtensionService load() method

@wewoor wewoor requested a review from mortalYoung April 27, 2022 06:57
@wewoor wewoor self-assigned this Apr 27, 2022
@wewoor wewoor added the bug Something isn't working label Apr 27, 2022
@wewoor wewoor added this to the 0.9.0-beta.5 milestone Apr 27, 2022
@wewoor wewoor linked an issue Apr 27, 2022 that may be closed by this pull request
feat: optimze the logger.ts #710
Closed
mortalYoung
mortalYoung approved these changes Apr 29, 2022
View reviewed changes
Copy link
Collaborator

@mortalYoung mortalYoung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@mortalYoung mortalYoung merged commit e4174e5 into refactor/workspaces Apr 29, 2022
@mortalYoung mortalYoung deleted the fix/logger branch April 29, 2022 06:06
@wewoor wewoor mentioned this pull request Jun 2, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mortalYoung mortalYoung mortalYoung approved these changes

Assignees

@wewoor wewoor

Labels

bug Something isn't working

Projects

None yet

Milestone

0.9.0-beta.5

Development

Successfully merging this pull request may close these issues.

feat: optimze the logger.ts

3 participants

@wewoor @mortalYoung