fix(postgresql): change func_application to add column_name and () #359
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liuxy0551
reviewed
Oct 17, 2024
Cythia828
approved these changes
Oct 17, 2024
LuckyFBB
changed the title
liuxy0551
approved these changes
Oct 17, 2024
HaydenOrz
reviewed
Oct 17, 2024
| | function_name (sconst | OPEN_PAREN func_arg_list sort_clause? CLOSE_PAREN sconst) | ||
| | function_name ( | ||
| sconst | ||
| | OPEN_PAREN (column_name | func_arg_list) sort_clause? CLOSE_PAREN sconst |
Collaborator
There was a problem hiding this comment.
column_name 是不是应该写到 func_arg_list 里面呢？
HaydenOrz
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#339
func_application 中作为函数
()是非必填，导致一些走 expression 的 column 匹配上 function_name将
()设置为必选，就能正常的走到 expression 中的 qualified_name