-
Notifications
You must be signed in to change notification settings - Fork 493
Improve Hungarian translations in DSpace 9.0 #4506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@kanasznagyzoltan : Could you resolve the merge conflicts in this PR? It's not currently testable/mergeable because GitHub is reporting "This branch has conflicts that must be resolved" |
|
Sorry, thanks @tdonohue, i am fixing till tomorrow. |
|
Hi @kanasznagyzoltan, |
# Conflicts: # src/assets/i18n/hu.json5
|
Hi @tdonohue I'm sorry for the delay — I’ve just resolved the merge conflict. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Thanks @kanasznagyzoltan ! I was able to give this a quick test today and the translation is working.
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin main
git worktree add -d .worktree/backport-4506-to-main origin/main
cd .worktree/backport-4506-to-main
git switch --create backport-4506-to-main
git cherry-pick -x a0c01fccf20fc8ddd475bfe40ef4f3c947bd9072 83e742832fc7d638fd9a9cbe310cc2dfbb1b0a34 9a5c530a902bcd89e7e150702c5b96b87b301c89 e100292e5d00ebd8a41a08f5213b144dc90b1b4f 16aecc43cedf9efdd42658dd9e9878c7416b2842 0ad9a9bb5a875713e9df69feedec6185d1b8ec33 91e82544655e5de831ef063eb50a3bef826e578d e6dcdf7dad4e3e2540ab4c935e32625e12f3cedd 558eca2fea0cc0969acd9fab849b2f7f41034ec8 8f2a292fb07c237e4032c13829ad123198125ae1 fc72709dc19657ef7bcef8ba721355ddbfbed518 af553a3c51dc5911072c12260ab95ea726c9a428 9b511a8de8c00f4929a81a9b0f9d2e64a93b18d3 827d1fcc65a2786b4d860556a7003ef83c42e450 |
* QREPO-0 improving HU translations * QREPO-0 improving HU translations * QREPO-0 HU translations: grant-request-copy messages * QREPO-0 improving HU translations * QREPO-0 HU translation improvements * QREPO-0 HU translation improvements * QREPO-0 HU translation improvements * QREPO-0 HU translation improvements * QREPO-0 HU translations improvements * QREPO-0 HU translation improvements * QREPO-0 HU translation improvements * QREPO-0 removing TODO comments * QREPO-0 inserting some missing new lines * QREPO-0 HU translation improvements
|
I've manually ported this PR to the |
|
Thanks for taking care of the port, @tdonohue . Makes sense to keep main and dspace-9_x aligned at this point. |
References
No related issues or PRs.
Description
This PR improves the Hungarian (hu) translations in DSpace 9.0. It adds missing i18n keys and improves several existing translations for clarity and consistency.
Instructions for Reviewers
This PR includes updates to the src/assets/i18n/hu.json file.
List of changes in this PR:
Added missing Hungarian translations for newly introduced i18n keys in DSpace 9.0
Reviewed and refined several existing Hungarian translations to better match context and improve user understanding
Ensured consistent terminology across sections (submission, search, access control, etc.)
How to test:
Switch your DSpace UI to the Hungarian language.
Navigate through the application, especially areas like submission forms, search filters, item preview, and user management.
Confirm that previously untranslated texts are now correctly translated and that the revised translations fit the UI contextually and linguistically.
Check for any visual layout issues caused by text length changes.
Checklist
This checklist provides a reminder of what we are going to look for when reviewing your PR. You do not need to complete this checklist prior creating your PR (draft PRs are always welcome).
However, reviewers may request that you complete any actions in this list if you have not done so. If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!
mainbranch of code (unless it is a backport or is fixing an issue specific to an older branch).npm run lintnpm run check-circ-deps)package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.