Skip to content

Conversation

@kanasznagyzoltan
Copy link
Contributor

References
No related issues or PRs.

Description
This PR improves the Hungarian (hu) translations in DSpace 9.0. It adds missing i18n keys and improves several existing translations for clarity and consistency.

Instructions for Reviewers
This PR includes updates to the src/assets/i18n/hu.json file.

List of changes in this PR:

Added missing Hungarian translations for newly introduced i18n keys in DSpace 9.0
Reviewed and refined several existing Hungarian translations to better match context and improve user understanding
Ensured consistent terminology across sections (submission, search, access control, etc.)
How to test:

Switch your DSpace UI to the Hungarian language.
Navigate through the application, especially areas like submission forms, search filters, item preview, and user management.
Confirm that previously untranslated texts are now correctly translated and that the revised translations fit the UI contextually and linguistically.
Check for any visual layout issues caused by text length changes.

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You do not need to complete this checklist prior creating your PR (draft PRs are always welcome).
However, reviewers may request that you complete any actions in this list if you have not done so. If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

  • My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using npm run lint
  • My PR doesn't introduce circular dependencies (verified via npm run check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • My PR aligns with Accessibility guidelines if it makes changes to the user interface.
  • My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
  • My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

@kanasznagyzoltan kanasznagyzoltan changed the title Dspace 9 x Improve Hungarian translations in DSpace 9.0 Jun 24, 2025
@tdonohue tdonohue added i18n / l10n Internationalisation and localisation, related to message catalogs 1 APPROVAL pull request only requires a single approval to merge labels Jun 24, 2025
@tdonohue tdonohue added the port to main This PR needs to be ported to `main` branch for the next major release label Jun 24, 2025
@tdonohue tdonohue moved this to 🙋 Needs Reviewers Assigned in DSpace 10.0 Release Jun 24, 2025
@tdonohue
Copy link
Member

@kanasznagyzoltan : Could you resolve the merge conflicts in this PR? It's not currently testable/mergeable because GitHub is reporting "This branch has conflicts that must be resolved"

@kanasznagyzoltan
Copy link
Contributor Author

Sorry, thanks @tdonohue, i am fixing till tomorrow.

@github-actions
Copy link

Hi @kanasznagyzoltan,
Conflicts have been detected against the base branch.
Please resolve these conflicts as soon as you can. Thanks!

@kanasznagyzoltan
Copy link
Contributor Author

Hi @tdonohue

I'm sorry for the delay — I’ve just resolved the merge conflict.
The PR is now up to date and ready for review again. Let me know if anything else needs adjustment!
It’s Friday today, but I’ll be watching for feedback over the weekend as well — happy to respond quickly if anything comes up!

Copy link
Member

@tdonohue tdonohue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks @kanasznagyzoltan ! I was able to give this a quick test today and the translation is working.

@github-project-automation github-project-automation bot moved this from 🙋 Needs Reviewers Assigned to 👍 Reviewer Approved in DSpace 10.0 Release Jun 30, 2025
@tdonohue tdonohue moved this to 👍 Reviewer Approved in DSpace Maintenance (9.x, 8.x, 7.6.x) Jun 30, 2025
@tdonohue tdonohue added this to the 9.1 milestone Jun 30, 2025
@tdonohue tdonohue merged commit 9be1562 into DSpace:dspace-9_x Jun 30, 2025
15 checks passed
@github-project-automation github-project-automation bot moved this from 👍 Reviewer Approved to ✅ Done in DSpace Maintenance (9.x, 8.x, 7.6.x) Jun 30, 2025
@dspace-bot
Copy link
Contributor

Backport failed for main, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin main
git worktree add -d .worktree/backport-4506-to-main origin/main
cd .worktree/backport-4506-to-main
git switch --create backport-4506-to-main
git cherry-pick -x a0c01fccf20fc8ddd475bfe40ef4f3c947bd9072 83e742832fc7d638fd9a9cbe310cc2dfbb1b0a34 9a5c530a902bcd89e7e150702c5b96b87b301c89 e100292e5d00ebd8a41a08f5213b144dc90b1b4f 16aecc43cedf9efdd42658dd9e9878c7416b2842 0ad9a9bb5a875713e9df69feedec6185d1b8ec33 91e82544655e5de831ef063eb50a3bef826e578d e6dcdf7dad4e3e2540ab4c935e32625e12f3cedd 558eca2fea0cc0969acd9fab849b2f7f41034ec8 8f2a292fb07c237e4032c13829ad123198125ae1 fc72709dc19657ef7bcef8ba721355ddbfbed518 af553a3c51dc5911072c12260ab95ea726c9a428 9b511a8de8c00f4929a81a9b0f9d2e64a93b18d3 827d1fcc65a2786b4d860556a7003ef83c42e450

tdonohue pushed a commit to tdonohue/dspace-angular that referenced this pull request Jun 30, 2025
* QREPO-0 improving HU translations

* QREPO-0 improving HU translations

* QREPO-0 HU translations: grant-request-copy messages

* QREPO-0 improving HU translations

* QREPO-0 HU translation improvements

* QREPO-0 HU translation improvements

* QREPO-0 HU translation improvements

* QREPO-0 HU translation improvements

* QREPO-0 HU translations improvements

* QREPO-0 HU translation improvements

* QREPO-0 HU translation improvements

* QREPO-0 removing TODO comments

* QREPO-0 inserting some missing new lines

* QREPO-0 HU translation improvements
@tdonohue
Copy link
Member

I've manually ported this PR to the main branch to "sync" that branch with these latest translations (since both main and dspace-9_x are almost identical at this time because major 10.0 work hasn't begun yet.) See #4518

@tdonohue tdonohue removed the port to main This PR needs to be ported to `main` branch for the next major release label Jun 30, 2025
@kanasznagyzoltan
Copy link
Contributor Author

Thanks for taking care of the port, @tdonohue . Makes sense to keep main and dspace-9_x aligned at this point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1 APPROVAL pull request only requires a single approval to merge i18n / l10n Internationalisation and localisation, related to message catalogs

Projects

Development

Successfully merging this pull request may close these issues.

3 participants