[CU-86b2qymcx] Enable k8s-injected credentials #51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This initial implementation requires low-level configuration of the client: ``` dnastack config contexts add data-connect-k8s dnastack config contexts use data-connect-k8s dnastack config endpoints add --type data_connect data-connect dnastack config endpoints set data-connect url https://collection-service.staging.dnastack.com/data-connect/ dnastack config endpoints set data-connect authentication.client_id loader-cronjob-client dnastack config endpoints set data-connect authentication.resource_url https://publisher-data.staging.dnastack.com/ dnastack config endpoints set data-connect authentication.token_endpoint https://wallet.staging.dnastack.com/oauth/token dnastack config endpoints set data-connect authentication.grant_type client_credentials dnastack config endpoints set data-connect authentication.client_assertion_file /var/run/secrets/kubernetes.io/serviceaccount/token ``` The plan for the future is to have `dnastack use ${service-registry-url}` detect if: * the file /var/run/secrets/kubernetes.io/serviceaccount/token exists * the terminal is non-interactive and if so, edit all the service registry endpoint authentication objects on the fly, making the following edits: * add `client_assertion_file` with the path to the k8s token * replace `client_id` with the one found in the `client_assertion_file` * replace `grant_type` with `client_credentials` * null out `client_secret` If this happens, the CLI will print a message that says so, and it'll offer some switch like `--no-k8s-auth` to inhibit this behaviour.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This initial implementation requires low-level configuration of the client:
The plan for the future is to have
dnastack use ${service-registry-url}detect if:and if so, edit all the service registry endpoint authentication objects on the fly, making the following edits:
client_assertion_filewith the path to the k8s tokenclient_idwith the one found in theclient_assertion_filegrant_typewithclient_credentialsclient_secretIf this happens, the CLI will print a message that says so, and it'll offer some switch like
--no-k8s-authto inhibit this behaviour.