Feature/admin #9
Merged
+2,261
−330
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
semin0151
approved these changes
Jan 9, 2026
Collaborator
There was a problem hiding this comment.
이 객체는 admin:profile에 있는 이유가 있을까요?
네이밍상으로는 범용적인 객체일 것 같아 문의드려요
Member
Author
There was a problem hiding this comment.
이 객체는 admin:profile에 있는 이유가 있을까요? 네이밍상으로는 범용적인 객체일 것 같아 문의드려요
해당 객체는 admin:profile:feature 내부에서만 소비되는 네비게이션 이벤트로 판단해
feature/admin/profile 하위에 위치시켰습니다 !
네이밍상 범용적으로 보일 수 있다는 의견을 반영하여
현재는 ProfileNavigationEvent로 네이밍을 명확히 변경했습니다 :)
sealed class ProfileNavigationEvent {
object PopBackStack : ProfileNavigationEvent()
}
Comment on lines
+153
to
+154
| @Composable | ||
| internal fun Content( |
Collaborator
There was a problem hiding this comment.
Content를 한번 더 감싸신 이유가 있으실까요?!
Member
Author
There was a problem hiding this comment.
Content를 한번 더 감싸신 이유가 있으실까요?!
상위 컴포저블에서는 uiState 수집과 네비게이션 등 부수효과를 처리하고,
UI 렌더링은 Content에서 담당하도록 분리했습니다 !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
구현 완료
테스트 영상
admin.mp4