Skip to content

fix: issue #2 added tests to get branch coverage 100% #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 7, 2022
Merged

Conversation

Dajamante
Copy link
Collaborator

@Dajamante Dajamante commented Feb 25, 2022

Describe your change:

Functions:
data_structures/queue/priority_queue_using_list.py and queue_on_pseudo_stack.py were fixed with updating path to allow doctest to run exceptions. Making tests for the two exceptions not covered. The coverage is now 100% according to the python coverage tool.

datastructure/binary_tree/binary_search_tree.py tests were standardized. Current coverage 65%

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@Dajamante Dajamante self-assigned this Feb 25, 2022
@Dajamante Dajamante linked an issue Feb 25, 2022 that may be closed by this pull request
@jacobmimms jacobmimms self-requested a review March 7, 2022 08:52
Copy link
Collaborator

@jacobmimms jacobmimms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jacobmimms jacobmimms merged commit c5b6646 into master Mar 7, 2022
@jacobmimms jacobmimms deleted the issue/2 branch March 7, 2022 08:53
jacobmimms pushed a commit that referenced this pull request Mar 7, 2022
@Dajamante Dajamante restored the issue/2 branch March 7, 2022 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat: fix tests in data_structures/queue/priority_queue_using_list.py
2 participants