Skip to content

Conversation

JLBegin
Copy link
Contributor

@JLBegin JLBegin commented Sep 24, 2025

No description provided.

@JLBegin JLBegin marked this pull request as ready for review September 24, 2025 02:08
@JLBegin JLBegin mentioned this pull request Sep 24, 2025
Copilot

This comment was marked as spam.

@marcandrevigneault marcandrevigneault self-assigned this Sep 25, 2025
@marcandrevigneault
Copy link
Contributor

Great idea to add this type of source.
One thing I don't like off the bat is that we have DivergentSource and ConvergentSource which both use a different method of telling the angle of spread. DivergentSource directly gets the divergence full fan angle and ConvergentSource uses focal. I think both should use the same metric OR allow both of them to be defined by either focal or angle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants