Skip to content

Implement IAsyncDisposable on CompositeDisposableServiceProvider #188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 7, 2025
Merged

Implement IAsyncDisposable on CompositeDisposableServiceProvider #188

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 20 additions & 1 deletion src/ConsoleAppFramework/Emitter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -838,7 +838,7 @@ public void EmitAsConsoleAppBuilder(SourceBuilder sb, DllReference dllReference)
internal static class ConsoleAppHostBuilderExtensions
{
class CompositeDisposableServiceProvider(IDisposable host, IServiceProvider serviceServiceProvider, IDisposable scope, IServiceProvider serviceProvider)
: IServiceProvider, IKeyedServiceProvider, IDisposable
: IServiceProvider, IKeyedServiceProvider, IDisposable, IAsyncDisposable
{
public object? GetService(Type serviceType)
{
Expand Down Expand Up @@ -868,6 +868,25 @@ public void Dispose()
}
host.Dispose();
}

public async ValueTask DisposeAsync()
{
await CastAndDispose(host);
await CastAndDispose(scope);
await CastAndDispose(serviceProvider);
await CastAndDispose(serviceServiceProvider);
GC.SuppressFinalize(this);

return;

static async ValueTask CastAndDispose<T>(T resource)
{
if (resource is IAsyncDisposable resourceAsyncDisposable)
await resourceAsyncDisposable.DisposeAsync();
else if (resource is IDisposable resourceDisposable)
resourceDisposable.Dispose();
}
}
}

internal static ConsoleApp.ConsoleAppBuilder ToConsoleAppBuilder(this IHostBuilder hostBuilder)
Expand Down