Limit Scope of OpenShift Auto Detect Discovery #2897
Merged
+15
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The OpenShift auto-detection logic has been updated to only check for server resources (and therefore the "SecurityContextConstraints" kind) in the "security.openshift.io" group. This is done to prevent a single broken (and related) API in the Kubernetes cluster from breaking the OpenShift detection logic, as can occur when checking all server groups and resources. Issue: [sc-13205]
cbandy
approved these changes
Dec 3, 2021
| // "security.openshift.io" Group, we'll return that this is an OpenShift | ||
| // environment | ||
| for _, rl := range resourceLists { | ||
| if strings.HasPrefix(rl.GroupVersion, sccGroup+"/") { |
There was a problem hiding this comment.
👍🏻 This also got rid of our GroupVersion matching/parsing.
| for _, rl := range resourceLists { | ||
| if strings.HasPrefix(rl.GroupVersion, sccGroup+"/") { | ||
| for _, r := range rl.APIResources { | ||
| groups, err := client.ServerGroups() |
There was a problem hiding this comment.
⛏️ The variable for the other calls is resourceList.
Suggested change
| groups, err := client.ServerGroups() | |
| groupList, err := client.ServerGroups() |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The OpenShift auto-detection logic has been updated to only check for server resources (and therefore the
SecurityContextConstraintskind) in thesecurity.openshift.iogroup. This is done to prevent a single broken (and related) API in the Kubernetes cluster from breaking the OpenShift detection logic, as can occur when checking all server groups and resources.Checklist:
Type of Changes:
What is the current behavior (link to any open issues here)?
The OpenShift auto-detection logic checks all server groups and resources.
[sc-13205]
What is the new behavior (if this is a feature change)?
The OpenShift auto-detection logic only checks for resources in the server group we care about.
Other Information:
N/A