Skip to content

Conversation

joanagmaia
Copy link
Contributor

Changes proposed ✍️

This piece of code:

    if (
      results.type === IntegrationType.GITHUB &&
      moment(results.updatedAt).isBefore(moment('2024-12-19'))
    ) {
      return null
    }

was added in this commit (commit even mentions "revert me:", since it was a temporary optimization) because of the GitHub Archive implementation. This was added to prevent any historical onboardings with archive for old integrations. Since the GitHub Archive is no longer active, this no longer makes sense -> This is actually preventing to re-onboard some of the older integrations to get missing data back.

Checklist ✅

  • Label appropriately with Feature, Improvement, or Bug.
  • Add screenshots to the PR description for relevant FE changes
  • New backend functionality has been unit-tested.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.

@joanagmaia joanagmaia requested a review from themarolt April 3, 2025 14:49
@joanagmaia joanagmaia self-assigned this Apr 3, 2025
@joanagmaia joanagmaia merged commit e2cb21e into main Apr 4, 2025
6 checks passed
@joanagmaia joanagmaia deleted the bugfix/updatedAt-check-onboarding branch April 4, 2025 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants