Skip to content

Conversation

@AlyssaCote
Copy link
Contributor

@AlyssaCote AlyssaCote commented Aug 12, 2024

SS_INFRA_BACKBONE has been updated to _SMARTSIM_INFRA_BACKBONE and SS_REQUEST_QUEUE is now _SMARTSIM_REQUEST_QUEUE.

@codecov
Copy link

codecov bot commented Aug 12, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Please upload report for BASE (mli-feature@74d6e78). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...tsim/_core/mli/infrastructure/environmentloader.py 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff               @@
##             mli-feature     #665   +/-   ##
==============================================
  Coverage               ?   81.44%           
==============================================
  Files                  ?       97           
  Lines                  ?     7659           
  Branches               ?        0           
==============================================
  Hits                   ?     6238           
  Misses                 ?     1421           
  Partials               ?        0           
Files with missing lines Coverage Δ
smartsim/_core/launcher/dragon/dragonBackend.py 35.77% <ø> (ø)
...tsim/_core/mli/infrastructure/environmentloader.py 0.00% <0.00%> (ø)

@AlyssaCote AlyssaCote requested review from ankona and mellis13 August 12, 2024 22:07
Copy link
Contributor

@mellis13 mellis13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@AlyssaCote AlyssaCote merged commit 391784c into CrayLabs:mli-feature Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants