Skip to content

Conversation

@AlyssaCote
Copy link
Contributor

This PR adds the Capnproto schemas and initial MessageHandler class and tests. This is very much a work in progress!

@AlyssaCote AlyssaCote requested a review from mellis13 June 4, 2024 16:48
@codecov
Copy link

codecov bot commented Jun 5, 2024

Codecov Report

Attention: Patch coverage is 0% with 204 lines in your changes missing coverage. Please review.

Project coverage is 53.35%. Comparing base (7d995bb) to head (60faf5d).
Report is 39 commits behind head on mli-feature.

Files with missing lines Patch % Lines
smartsim/_core/mli/message_handler.py 0.00% 204 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff                @@
##           mli-feature     #607       +/-   ##
================================================
- Coverage        71.53%   53.35%   -18.18%     
================================================
  Files               78       79        +1     
  Lines             6000     6187      +187     
================================================
- Hits              4292     3301      -991     
- Misses            1708     2886     +1178     
Files with missing lines Coverage Δ
smartsim/_core/mli/message_handler.py 0.00% <0.00%> (ø)

... and 46 files with indirect coverage changes

Copy link
Contributor

@mellis13 mellis13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some quick questions/comments/suggestions

@al-rigazzi al-rigazzi self-requested a review June 5, 2024 21:39
Copy link
Collaborator

@al-rigazzi al-rigazzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Some general comments, possibly tending to over-engineering.

@staticmethod
def _assign_custom_request_attributes(
request: request_capnp.Request,
custom_attrs: t.Union[
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm slightly concerned by extensibility/maintainability of this type: do we need to keep coming to this portion of the code and add new XyzRequestAttributes every time we support a new library? Is there a more flexible way? ("No" is an acceptable answer).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am also concerned about the extensibility/maintainability of this type! Currently I think we will just need to come back and add to it because I need to check the passed in schema name and set the union field depending on that. So it might be no for now, but hopefully I can come up with a better way in the future.

@AlyssaCote AlyssaCote changed the title [WIP] Initial MLI schemas and MessageHandler class Initial MLI schemas and MessageHandler class Jun 11, 2024
@AlyssaCote AlyssaCote merged commit d2fd6a7 into mli-feature Jun 11, 2024
@mellis13 mellis13 deleted the mli branch September 11, 2024 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants