Skip to content

Update required go version to v1.14 in go.mod #248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 9, 2020
Merged

Update required go version to v1.14 in go.mod #248

merged 3 commits into from
Aug 9, 2020

Conversation

orkunkl
Copy link
Contributor

@orkunkl orkunkl commented Aug 7, 2020

Resolve #245

@orkunkl orkunkl requested a review from alpe as a code owner August 7, 2020 08:44
@codecov
Copy link

codecov bot commented Aug 7, 2020 •
edited
Loading

Codecov Report

Merging #248 into master will decrease coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #248      +/-   ##
==========================================
- Coverage   72.67%   72.60%   -0.08%     
==========================================
  Files          27       27              
  Lines        2657     2657              
==========================================
- Hits         1931     1929       -2     
- Misses        614      616       +2     
  Partials      112      112
Impacted Files Coverage Δ
lcd_test/helpers.go 75.00% <0.00%> (-0.72%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4592325...cd3e318. Read the comment docs.

alpe
alpe reviewed Aug 7, 2020
View reviewed changes
Copy link
Contributor

@alpe alpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also update the circleCI config. I had run into build issues with 1.14 syntax before already

@orkunkl orkunkl changed the title Update required go version go v1.14 in go.mod Update required go version to v1.14 in go.mod Aug 7, 2020
@orkunkl orkunkl requested a review from alpe August 7, 2020 16:02
ethanfrey
ethanfrey approved these changes Aug 7, 2020
View reviewed changes
Copy link
Contributor

@ethanfrey ethanfrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice update, but you also need to update the README

ethanfrey
ethanfrey approved these changes Aug 9, 2020
View reviewed changes
Copy link
Contributor

@ethanfrey ethanfrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@ethanfrey ethanfrey merged commit 70a1dba into master Aug 9, 2020
@ethanfrey ethanfrey deleted the mod-update-go branch August 9, 2020 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alpe alpe Awaiting requested review from alpe

1 more reviewer

@ethanfrey ethanfrey ethanfrey approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update required go version to 1.14+
3 participants
@orkunkl @alpe @ethanfrey