Skip to content

Conversation

chipshort
Copy link
Contributor

@chipshort chipshort commented May 21, 2025

Original issue: CosmWasm/cosmwasm#2398
CosmWasm PR: CosmWasm/cosmwasm#2484

@chipshort chipshort changed the title Add funds to IBC destination callback if it's a transfer message Add Transfer special handling to IBC destination callback if it's a transfer message May 22, 2025
@chipshort chipshort force-pushed the co/ibc-callbacks-funds branch from 41a5ef9 to cf6c90a Compare May 22, 2025 17:36
Copy link
Contributor

@kulikthebird kulikthebird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in general. Let's make sure that the two things I've mentioned are checked before merging it.

@chipshort chipshort requested a review from kulikthebird May 26, 2025 12:29
Copy link
Contributor

@kulikthebird kulikthebird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chipshort chipshort force-pushed the co/ibc-callbacks-funds branch from 1aa8e74 to 5467f1e Compare June 23, 2025 12:04
@chipshort chipshort marked this pull request as ready for review June 23, 2025 12:05
@chipshort chipshort requested a review from pinosu June 23, 2025 12:05
Copy link

codecov bot commented Jun 23, 2025

Codecov Report

Attention: Patch coverage is 11.11111% with 24 lines in your changes missing coverage. Please review.

Project coverage is 44.94%. Comparing base (6ff32cc) to head (5467f1e).
Report is 16 commits behind head on main.

Files with missing lines Patch % Lines
x/wasm/ibc.go 7.69% 24 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2267      +/-   ##
==========================================
- Coverage   45.03%   44.94%   -0.09%     
==========================================
  Files          80       80              
  Lines       11034    11056      +22     
==========================================
  Hits         4969     4969              
- Misses       5626     5648      +22     
  Partials      439      439              
Files with missing lines Coverage Δ
app/app.go 86.59% <100.00%> (ø)
x/wasm/ibc.go 12.30% <7.69%> (-1.18%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@pinosu pinosu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! LGTM 👍

@chipshort chipshort merged commit 0461d17 into main Jun 23, 2025
18 of 19 checks passed
@chipshort chipshort deleted the co/ibc-callbacks-funds branch June 23, 2025 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants