-
Notifications
You must be signed in to change notification settings - Fork 515
Add Transfer
special handling to IBC destination callback if it's a transfer message
#2267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
funds
to IBC destination callback if it's a transfer messageTransfer
special handling to IBC destination callback if it's a transfer message
41a5ef9
to
cf6c90a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good in general. Let's make sure that the two things I've mentioned are checked before merging it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
1aa8e74
to
5467f1e
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2267 +/- ##
==========================================
- Coverage 45.03% 44.94% -0.09%
==========================================
Files 80 80
Lines 11034 11056 +22
==========================================
Hits 4969 4969
- Misses 5626 5648 +22
Partials 439 439
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! LGTM 👍
Original issue: CosmWasm/cosmwasm#2398
CosmWasm PR: CosmWasm/cosmwasm#2484