Hide StakingMsg and CosmosMsg::Staking behind feature flag #878
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanfrey
approved these changes
Apr 14, 2021
Contributor
ethanfrey
left a comment
ethanfrey
left a comment
There was a problem hiding this comment.
Looks good.
Maybe add this flag for ibc-reflect-send?
| } | ||
| } | ||
| }, | ||
| "StakingMsg": { |
Contributor
There was a problem hiding this comment.
Ah, so the ibc-reflect-send doesn't import the "staking" feature, so it doesn't support relaying these messages.
I would actually add the "staking" feature to cosmwasm-std in Cargo.toml so these are still supported.
Member
Author
There was a problem hiding this comment.
okay, will add. The same applies for ibc-reflect, right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.