-
Notifications
You must be signed in to change notification settings - Fork 391
Show how to verify Ethereum signatures #797
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Okay, this is ready now. This does not need to be perfect with all edge case testing, as it is just a demo contract to prove the point. |
maurolacy
reviewed
Feb 25, 2021
Contributor
maurolacy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm.
maurolacy
reviewed
Feb 25, 2021
Co-authored-by: Mauro Lacy <[email protected]>
072e2b3 to
d059c2b
Compare
maurolacy
approved these changes
Feb 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This shows how a contract can verify an Ethereum transaction given the information stored on chain. It is feature complete. We just need to expose
verify_transactionas part of theHandleMsg. Opening a draft to allow early review.It turns out we don't need a DER decoder as the Ethereum nodes provide signatures as three fields (r, s, v) directly.
Closes #753