Skip to content

Conversation

@webmaster128
Copy link
Member

@webmaster128 webmaster128 commented Feb 24, 2021

This shows how a contract can verify an Ethereum transaction given the information stored on chain. It is feature complete. We just need to expose verify_transaction as part of the HandleMsg. Opening a draft to allow early review.

It turns out we don't need a DER decoder as the Ethereum nodes provide signatures as three fields (r, s, v) directly.

Closes #753

@webmaster128 webmaster128 marked this pull request as ready for review February 25, 2021 08:17
@webmaster128
Copy link
Member Author

Okay, this is ready now. This does not need to be perfect with all edge case testing, as it is just a demo contract to prove the point.

Copy link
Contributor

@maurolacy maurolacy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@webmaster128 webmaster128 added the automerge See mergify.io label Feb 25, 2021
@webmaster128 webmaster128 merged commit 29b791a into main Feb 25, 2021
@webmaster128 webmaster128 deleted the verify-ethereum-sig branch February 25, 2021 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automerge See mergify.io

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support Ethereum secp256k1 signature verification

3 participants