Crypto api ed25519 #771
Merged
Crypto api ed25519 #771
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webmaster128
reviewed
Feb 5, 2021
Member
webmaster128
left a comment
webmaster128
left a comment
There was a problem hiding this comment.
Some first thoughts. Looks like this is easy once secp256k1 is done.
maurolacy
force-pushed
the
crypto-api-ed25519
branch
3 times, most recently
from
ff8d608 to
d998288
Compare
maurolacy
force-pushed
the
crypto-api-rust-only
branch
3 times, most recently
from
f0501ea to
25eecd4
Compare
maurolacy
force-pushed
the
crypto-api-ed25519
branch
4 times, most recently
from
27d40e3 to
78ed1dd
Compare
maurolacy
changed the base branch from
crypto-api-rust-only
to
crypto-api-package
maurolacy
force-pushed
the
crypto-api-ed25519
branch
3 times, most recently
from
143431b to
f1d389c
Compare
Implement secp256k1_verify for MockApi
This reverts commit 756a809.
Adapt/extend constants names
Add dummy ed25519_verify mock
Adapt/extend constants names
maurolacy
force-pushed
the
crypto-api-ed25519
branch
from
a49b154 to
accf545
Compare
webmaster128
approved these changes
Feb 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #755.
Update: Rebased against
crypto-api-package. Ready for review.Update 2: Rebased against latest
crypto-api-package. Added contract tests.