-
Notifications
You must be signed in to change notification settings - Fork 390
added call_migrate_works function in test modules. #731
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall. If you apply the suggestions and mark this as ready for review, we can merge.
packages/vm/src/calls.rs
Outdated
| verifier: new_verifier, | ||
| }; | ||
| let info = mock_info(creator.as_str(), &[]); | ||
| let res = call_migrate(&mut instance, &mock_env(), &info, msg); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need a different call_migrate here than in the integration test. The integration test uses https://github.com/CosmWasm/cosmwasm/blob/master/packages/vm/src/testing/calls.rs (i.e. from the testing:: module) but here we use a similar but different function from https://github.com/CosmWasm/cosmwasm/blob/master/packages/vm/src/calls.rs. This does not require the MigrateMsg type. Instead pass the migrate message as JSON.
|
I just realized the tests don't pass. If you want to run most tests locally, use the big first block from https://github.com/CosmWasm/cosmwasm/blob/master/README.md#developing. Or pick some of the commands that are relevant. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Is this ready to merge?
@webmaster128 it is ready to merge. |
|
Merci! |
Closes #715
packages/vm/src/calls.rsfn call_migrate_worksintestsmodule.Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.