V3 mods rebase test #4
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modify prod build Move package over to @connected-home Downgrade jest and babel-jest to support V3 Undo commented template section. Should work now that were referencing react-scripts as part of CRA rather than a folder in our project Delete yarn.lock file and use npm for this proj instead Remove fs package that was added by us for some reason Add HivehomeWebappFaviconsWebpackPlugin with proper config Remove path package from devDependencies
Adjust a few bits so that Jest works properly with V3 Add property to jest config for matching jest files in this lower version of jest
…the end Bump favicon plugin ref to 2.0.0 Change favicon config to use ios rather than iphone key Bump versions
JamieDixon
force-pushed
the
v3-mods-rebase-test
branch
from
4d56a8a to
600e989
Compare
|
looks dope |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.