- feature: add transformation of conditional operands at the end of p… #282
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…arseArgs. The code checks the check task type before doing any conversions. Currently it only converts timestamps
Contributor
|
Would be great if it would be more generic. |
Contributor
how long is a month? :) there is already Line 50 in bdcf854 |
- add the ability to ascertain the beginning of this week this_day i.e today, this_week, this_month, this_year - add the ability to move forward/backward in time using the suffixes 'ago' and 'from_now_on' - add the ability to parse arbitrary numbers for the temporal move, as long as its given in digits - now move in time with the library function, is more robust against leap days etc. - integrate the parsing of such time keywords into the unit system. now these types of time phrases can be used anywhere in the code
…combinations - integrate date keyword parsing better into the conditional operand parsing. If the regex for detecting an operand fails, it also tries to parse it as a date keyword. - more explanatory errors in conditional parsing. Fix error propagation, previously some cases were just returning nils - write a test function for parsing the date keyword
…rectly to the next steps. - Fix a logic error in the time parser test - Make time parser test linux only - Trying to pass CI tests - Fix linter errors about function and variable names
…l locally. The CI pipeline might be messing with the folder.
…the condition - the date parsing now uses this timezone when determining times - stop using time.UTC or time.Local except for testing.
sni
reviewed
Nov 20, 2025
added 2 commits
November 20, 2025 16:40
…keyword-transformations
…nly runs on linux now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There might be a better place to put the transformation function to.
Additionally, I save checks where I can perform time keyword transformations in a map. If there is an object detailing different checks, maybe adding a flag that says to transform keywords for time, size , percentage etc. is better.
I also did not run any tests yet.