Actually add/remove onfloor status like advertised #71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liam-middlebrook
force-pushed
the
onfloor-status-fix
branch
3 times, most recently
from
7aecd9f to
45a9596
Compare
stevenmirabito
approved these changes
Sep 22, 2016
|
|
||
| # Only update if there's a diff | ||
| logger.info('backend', action="edit %s active: %s" % (uid, active_member)) | ||
| if ldap_is_active(uid) != active_member: |
There was a problem hiding this comment.
We should move this logic into the actual LDAP methods so this if statement doesn't need to be sprinkled throughout our controllers. I've opened #72 so this can be looked at in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now works as advertised for onfloor status changes!!!!!!