Fixing idempotency of require_singleuser_auth bash remediation script #13981
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Rationale:
sedcommand inbash_ensure_ini_configin this particular rule causes replacement of ALLExecStartwithExecStart=\nExecStart=-/usr/lib/systemd/systemd-sulogin-shell rescueadditionally
/etc/systemd/system/rescue.service.d/10-oscap.confis being checked more than a single time during the remediationin result multiple duplicated
ExecStartentries are appended to a file and amount of the additional duplicates is increased after every single run of the remediation scriptthis macro should probably not be used to replace multiple entries across the entire file
Fixes https://issues.redhat.com/browse/RHEL-106811
Review Hints:
bash_ensure_ini_configis suppose to prevent file changes, in casekey=valuealready exists in the file