Skip to content

Conversation

@Arden97
Copy link
Contributor

@Arden97 Arden97 commented Oct 3, 2025

Description:

  • Fixing a macro that causes rule's idempotency

Rationale:

  • sed command in bash_ensure_ini_config in this particular rule causes replacement of ALL ExecStart with ExecStart=\nExecStart=-/usr/lib/systemd/systemd-sulogin-shell rescue

  • additionally /etc/systemd/system/rescue.service.d/10-oscap.conf is being checked more than a single time during the remediation

  • in result multiple duplicated ExecStart entries are appended to a file and amount of the additional duplicates is increased after every single run of the remediation script

  • this macro should probably not be used to replace multiple entries across the entire file

  • Fixes https://issues.redhat.com/browse/RHEL-106811

Review Hints:

  • fix in bash_ensure_ini_config is suppose to prevent file changes, in case key=value already exists in the file

@openshift-ci
Copy link

openshift-ci bot commented Oct 3, 2025

Hi @Arden97. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label Oct 3, 2025
@Arden97 Arden97 marked this pull request as draft October 3, 2025 16:58
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Used by openshift-ci bot. label Oct 3, 2025
@Arden97 Arden97 force-pushed the singleuser_auth_duplicate_lines branch from 7594d6a to 779f5b7 Compare October 6, 2025 14:55
@Arden97 Arden97 marked this pull request as ready for review October 6, 2025 17:29
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Used by openshift-ci bot. label Oct 6, 2025
@Mab879 Mab879 self-assigned this Oct 6, 2025
@Mab879 Mab879 added this to the 0.1.79 milestone Oct 6, 2025
Copy link
Member

@Mab879 Mab879 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whitespace errors.

@Arden97 Arden97 force-pushed the singleuser_auth_duplicate_lines branch from 1214db7 to f05b43c Compare October 7, 2025 07:38
@Arden97 Arden97 force-pushed the singleuser_auth_duplicate_lines branch from f05b43c to 34ba43b Compare October 7, 2025 15:31
@Mab879 Mab879 merged commit 311d8df into ComplianceAsCode:master Oct 7, 2025
122 of 126 checks passed
@Arden97 Arden97 deleted the singleuser_auth_duplicate_lines branch October 8, 2025 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ok-to-test Used by openshift-ci bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants