Add test module for package health #46
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janosh
added
testing
checks that we're correctly packaging data files
janosh
force-pushed
the
test-pkg-includes-all-json
branch
from
f342b74 to
8b84866
Compare
was only added in py3.10
janosh
force-pushed
the
test-pkg-includes-all-json
branch
from
7b609d3 to
77c66f9
Compare
janosh
force-pushed
the
test-pkg-includes-all-json
branch
from
82a9b2b to
fcd52d9
Compare
Collaborator
Author
|
For later reference, there were still JSON files missing from the package after #45. This PR should have fixed it for real. |
janosh
added a commit
that referenced
this pull request
Jun 16, 2022
* add module tests/test_package.py with test_egg_sources() checks that we're correctly packaging data files * refactor test_egg_sources() to not use glob(root_dir=str) was only added in py3.10 * fix including JSON data files in the package (for real this time)
CompRhys
pushed a commit
that referenced
this pull request
Jun 30, 2022
* add module tests/test_package.py with test_egg_sources() checks that we're correctly packaging data files * refactor test_egg_sources() to not use glob(root_dir=str) was only added in py3.10 * fix including JSON data files in the package (for real this time)
CompRhys
pushed a commit
that referenced
this pull request
Jun 30, 2022
* add module tests/test_package.py with test_egg_sources() checks that we're correctly packaging data files * refactor test_egg_sources() to not use glob(root_dir=str) was only added in py3.10 * fix including JSON data files in the package (for real this time)
CompRhys
pushed a commit
that referenced
this pull request
Jul 1, 2022
* add module tests/test_package.py with test_egg_sources() checks that we're correctly packaging data files * refactor test_egg_sources() to not use glob(root_dir=str) was only added in py3.10 * fix including JSON data files in the package (for real this time)
CompRhys
pushed a commit
that referenced
this pull request
Jul 1, 2022
* add module tests/test_package.py with test_egg_sources() checks that we're correctly packaging data files * refactor test_egg_sources() to not use glob(root_dir=str) was only added in py3.10 * fix including JSON data files in the package (for real this time)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tests/test_package.pyonly contains 1 test for now:test_egg_sources()which checks we're correctly packaging all JSON files underaviary/.Should prevent issues like #45 from happening again.