Bugfix/cleanup commandline options #178
Conversation
ZSPACE-12467 Check if the file is MS type
Feature/support non ms instruments
ZSPACE-12730 Try to close the underlying stream.
unique channel name
add expected runtime
# Conflicts: # RawFileParser.cs # Writer/MetadataWriter.cs # Writer/MzMlSpectrumWriter.cs
Bugfix/treat last spectrum 0
There was a problem hiding this comment.
@wolfgangcolsman Could you, please, comment on what was the reason for implementing this change?
There was a problem hiding this comment.
If I understand correctly the implemented changes, the only difference is the selection of the MS device. However, if the RAW file does not contain MS data, generating MGF is impossible. We check for the presence of MS data earlier, thus, we should never come to this point if there was no MS data, or it was not selected before.
Is there an example when this assumption does not hold?
There was a problem hiding this comment.
The same as MGFParser, there is a guard upstream, thus, we should not arrive in WritePScans if the MS device is not selected already.
| } | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
MSAnalog chromatograms are taken care of at the same time as Analog ones.
Was the PR against the latest commit?
There was a problem hiding this comment.
A lot of changes are coming from commits before v 1.4.3 and, likely, were taken care of already.
I will suggest keeping our version and "cherry-picking" only necessary changes.
@wolfgangcolsman could you summarize what was broken?
5 participants
The command-line options have been inconsistent