Skip to content

Upgraded Dismiss button to be legible at 225% text display setting #4249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 16, 2021
Merged

Upgraded Dismiss button to be legible at 225% text display setting #4249

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3237e69
Upgraded Dismiss button to behave at 225% setting
XAML-Knight Sep 15, 2021
a094881
Removed excess white space before transform element
XAML-Knight Sep 15, 2021
f0e1617
Consistent 1 pixel Y transform
XAML-Knight Sep 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion Microsoft.Toolkit.Uwp.SampleApp/SamplePages/InAppNotification/InAppNotificationXaml.bind
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,7 @@
<Setter Property="Foreground" Value="{ThemeResource ApplicationForegroundThemeBrush}" />
<Setter Property="Width" Value="40" />
<Setter Property="Height" Value="40" />
<Setter Property="Padding" Value="4" />
<Setter Property="UseSystemFocusVisuals" Value="True" />
<Setter Property="HighContrastAdjustment" Value="None" />
<Setter Property="Template">
Expand Down Expand Up @@ -264,7 +265,7 @@
VerticalAlignment="Center"
Visibility="{Binding ShowDismissButton, ElementName=ExampleCustomInAppNotification}">
<Button.RenderTransform>
<TranslateTransform x:Name="DismissButtonTransform" X="25" Y="-5"/>
<TranslateTransform x:Name="DismissButtonTransform" X="20" Y="1"/>
</Button.RenderTransform>
</Button>
</Grid>
Expand Down
4 changes: 3 additions & 1 deletion Microsoft.Toolkit.Uwp.UI.Controls.Core/InAppNotification/Styles/MSEdgeNotificationStyle.xaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@
<Setter Property="Foreground" Value="{ThemeResource ApplicationForegroundThemeBrush}" />
<Setter Property="Width" Value="{StaticResource SystemControlMSEdgeNotificationDismissButtonSize}" />
<Setter Property="Height" Value="{StaticResource SystemControlMSEdgeNotificationDismissButtonSize}" />
<Setter Property="Padding" Value="4" />
<Setter Property="UseSystemFocusVisuals" Value="True" />
<Setter Property="HighContrastAdjustment" Value="None" />
<Setter Property="Template">
Expand Down Expand Up @@ -150,9 +151,10 @@
FontFamily="Segoe MDL2 Assets"
FontSize="12"
VerticalAlignment="Top"
Padding="4"
Style="{StaticResource DismissTextBlockButtonStyle}">
<Button.RenderTransform>
<TranslateTransform x:Name="DismissButtonTransform" X="25" Y="-5"/>
<TranslateTransform x:Name="DismissButtonTransform" X="20" Y="2"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are using Y="1" in the .bind. I guess we should have the same value in the two files ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@XAML-Knight any reason for this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went with what looked good, visually. Would be nice to have a consistent layout, even though the difference is only 1 pixel between the two button transforms.

</Button.RenderTransform>
</Button>
</Grid>
Expand Down