Skip to content

Conversation

Sergio0694
Copy link
Member

Fixes #4225

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

Compilation fails If the Microsoft MVVM Toolkit source generator attribute [ObservableProperty] is in a #region block.

What is the new behavior?

The generated code is now correct when regions are used.

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • New component
    • Pull Request has been submitted to the documentation repository instructions. Link:
    • Added description of major feature to project description for NuGet package (4000 total character limit, so don't push entire description over that)
    • If control, added to Visual Studio Design project
  • Sample in sample app has been added / updated (for bug fixes / features)
  • New major technical changes in the toolkit have or will be added to the Wiki e.g. build changes, source generators, testing infrastructure, sample creation changes, etc...
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes

@Sergio0694 Sergio0694 added bug 🐛 An unexpected issue that highlights incorrect behavior .NET Components which are .NET based (non UWP specific) mvvm-toolkit 🧰 Issues/PRs for the Microsoft.Toolkit.Mvvm package labels Sep 4, 2021
@Sergio0694 Sergio0694 added this to the 7.1 milestone Sep 4, 2021
@ghost
Copy link

ghost commented Sep 16, 2021

Hello @RosarioPulella!

Because this pull request has the auto merge :zap: label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit 0d73af7 into CommunityToolkit:main Sep 16, 2021
@Sergio0694 Sergio0694 deleted the bugfix/generated-properties-within-regions branch September 16, 2021 18:20
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto merge ⚡ bug 🐛 An unexpected issue that highlights incorrect behavior mvvm-toolkit 🧰 Issues/PRs for the Microsoft.Toolkit.Mvvm package .NET Components which are .NET based (non UWP specific) priority 🚩
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MVVM Source Generators: CS1038 Error if [ObservableProperty] attribute is in a #region block
3 participants