Skip to content

Conversation

azchohfi
Copy link
Contributor

@azchohfi azchohfi commented Aug 23, 2021

Fixes #4190

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

Test_ConstrainedBox_AllInfinite_AspectBothFallback fails on 150% DPI

What is the new behavior?

Test_ConstrainedBox_AllInfinite_AspectBothFallback works on any DPI.

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Pull Request has been submitted to the documentation repository instructions. Link:
  • Sample in sample app has been added / updated (for bug fixes / features)
  • New major technical changes in the toolkit have or will be added to the Wiki e.g. build changes, source generators, testing infrastructure, sample creation changes, etc...
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes

Other information

@ghost
Copy link

ghost commented Aug 23, 2021

Thanks azchohfi for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

@ghost ghost requested review from michael-hawker and Rosuavio August 23, 2021 20:29
@ghost ghost added the bug 🐛 An unexpected issue that highlights incorrect behavior label Aug 24, 2021
@azchohfi azchohfi merged commit cc562b3 into main Aug 24, 2021
@delete-merged-branch delete-merged-branch bot deleted the constrainedBoxTestFix branch August 24, 2021 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 An unexpected issue that highlights incorrect behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test_ConstrainedBox_AllInfinite_AspectBothFallback fails on high DPI
2 participants