Skip to content

[SettingsControls] Null check and removing unused strings #284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 14, 2022
Merged

[SettingsControls] Null check and removing unused strings #284

merged 2 commits into from
Oct 14, 2022

Conversation

niels9001
Copy link
Collaborator

  • Adding null check
  • Remove unused strings

@michael-hawker michael-hawker merged commit f7444fe into main Oct 14, 2022
@delete-merged-branch delete-merged-branch bot deleted the niels9001/settingscontrol-fix branch October 14, 2022 18:10
@michael-hawker michael-hawker added the experiment 🧪 Used to track issues that are experiments (or their linked discussions) label Nov 2, 2022
@michael-hawker michael-hawker linked an issue Nov 2, 2022 that may be closed by this pull request
🧪 [Experiment] SettingsCard & SettingsExpander #216
Closed
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michael-hawker michael-hawker michael-hawker approved these changes

Assignees

No one assigned

Labels

experiment 🧪 Used to track issues that are experiments (or their linked discussions)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

🧪 [Experiment] SettingsCard & SettingsExpander

2 participants

@niels9001 @michael-hawker