-
Notifications
You must be signed in to change notification settings - Fork 142
Remove stray "." argument passed to cargo run in RustAppHostingExtension.cs #1016
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: aaronpowell <[email protected]>
Minimum allowed line rate is |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR fixes a bug where the Rust integration was passing an invalid "." argument to cargo run, causing the command to fail. The fix removes the unnecessary argument, allowing cargo to correctly use the working directory.
- Removes the stray "." argument from the
cargo runcommand inRustAppHostingExtension.cs - Updates test assertions in
AddRustAppTests.csto verify the corrected command arguments
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/CommunityToolkit.Aspire.Hosting.Rust/RustAppHostingExtension.cs |
Removed the invalid "." argument from both conditional branches of the args array construction |
tests/CommunityToolkit.Aspire.Hosting.Rust.Tests/AddRustAppTests.cs |
Updated test assertions to expect only "run" argument (without ".") in both test methods |
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
|
It's very odd how this test passed in
|
|
Manually tested and |
Closes #1011
cargo rundoes not accept "." as a positional argument (unlikego run .). The current code producescargo run .which fails.Changes
RustAppHostingExtension.csAddRustAppTests.csto expect correct argsBefore:
cargo run . [--args]After:
cargo run [--args]PR Checklist
Other information
Cargo uses the working directory (already set correctly) to find
Cargo.toml. If a different manifest location is needed,--manifest-pathshould be used instead.Original prompt
cargo runin RustAppHostingExtension.cs #1011💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.