[feat] Add remote config support for model upload and asset update feature flags #7143

luke-mino-altherr · 2025-12-04T01:08:44Z

Summary

Feature flags for model upload button and asset update options now check remote config from /api/features first, falling back to websocket feature flags.

Changes

What: Added model_upload_button_enabled and asset_update_options_enabled to RemoteConfig type
What: Updated feature flag getters to prioritize remote config over websocket flags
Why: Enables dynamic feature control without requiring websocket connection, consistent with other feature flags pattern

Review Focus

Pattern consistency with other remote config feature flags
Proper fallback behavior when remote config is unavailable

┆Issue is synchronized with this Notion page by Unito

…ature flags 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>

coderabbitai · 2025-12-04T01:08:58Z

📝 Walkthrough

Walkthrough

Remote configuration support was added for two feature flags. The RemoteConfig type now includes optional fields for model upload button and asset update options. The useFeatureFlags composable was updated to prioritize these remote config values over existing API calls with fallback behavior preserved.

Changes

Cohort / File(s)	Summary
Remote config type extension `src/platform/remoteConfig/types.ts`	Added two optional boolean fields to RemoteConfig: `model_upload_button_enabled` and `asset_update_options_enabled`
Feature flags composable logic `src/composables/useFeatureFlags.ts`	Updated `modelUploadButtonEnabled` and `assetUpdateOptionsEnabled` to check remote config values first, then fall back to existing API calls (MODEL_UPLOAD_BUTTON_ENABLED and ASSET_UPDATE_OPTIONS_ENABLED)

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch feat/remote-config-feature-flags

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e9d5ce7 and 8d40534.

📒 Files selected for processing (2)

src/composables/useFeatureFlags.ts (2 hunks)
src/platform/remoteConfig/types.ts (1 hunks)

🧰 Additional context used

📓 Path-based instructions (15)

**/*.{vue,ts,tsx}

📄 CodeRabbit inference engine (.cursorrules)

**/*.{vue,ts,tsx}: Leverage VueUse functions for performance-enhancing utilities
Use vue-i18n in Composition API for any string literals and place new translation entries in src/locales/en/main.json

Files:

src/composables/useFeatureFlags.ts
src/platform/remoteConfig/types.ts

**/*.{ts,tsx,js}

📄 CodeRabbit inference engine (.cursorrules)

Use es-toolkit for utility functions

Files:

src/composables/useFeatureFlags.ts
src/platform/remoteConfig/types.ts

**/*.{ts,tsx}

📄 CodeRabbit inference engine (.cursorrules)

Use TypeScript for type safety

**/*.{ts,tsx}: Never use any type - use proper TypeScript types
Never use as any type assertions - fix the underlying type issue

Files:

src/composables/useFeatureFlags.ts
src/platform/remoteConfig/types.ts

**/*.{ts,tsx,js,vue}

📄 CodeRabbit inference engine (.cursorrules)

Implement proper error handling in components and services

**/*.{ts,tsx,js,vue}: Use 2-space indentation, single quotes, no semicolons, and maintain 80-character line width as configured in .prettierrc
Organize imports by sorting and grouping by plugin, and run pnpm format before committing

Files:

src/composables/useFeatureFlags.ts
src/platform/remoteConfig/types.ts

src/**/*.{vue,ts}

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

src/**/*.{vue,ts}: Leverage VueUse functions for performance-enhancing styles
Implement proper error handling
Use vue-i18n in composition API for any string literals. Place new translation entries in src/locales/en/main.json

Files:

src/composables/useFeatureFlags.ts
src/platform/remoteConfig/types.ts

src/**/*.ts

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

src/**/*.ts: Use es-toolkit for utility functions
Use TypeScript for type safety

Files:

src/composables/useFeatureFlags.ts
src/platform/remoteConfig/types.ts

**/*.{ts,tsx,js,jsx,vue}

📄 CodeRabbit inference engine (CLAUDE.md)

Use camelCase for variable and setting names in TypeScript/Vue files

Files:

src/composables/useFeatureFlags.ts
src/platform/remoteConfig/types.ts

**/*.{ts,tsx,vue}

📄 CodeRabbit inference engine (CLAUDE.md)

**/*.{ts,tsx,vue}: Use const settingStore = useSettingStore() and settingStore.get('Comfy.SomeSetting') to retrieve settings in TypeScript/Vue files
Use await settingStore.set('Comfy.SomeSetting', newValue) to update settings in TypeScript/Vue files
Check server capabilities using api.serverSupportsFeature('feature_name') before using enhanced features
Use api.getServerFeature('config_name', defaultValue) to retrieve server feature configuration

Enforce ESLint rules for Vue + TypeScript including: no floating promises, no unused imports, and i18n raw text restrictions in templates

Files:

src/composables/useFeatureFlags.ts
src/platform/remoteConfig/types.ts

**/*.ts

📄 CodeRabbit inference engine (CLAUDE.md)

**/*.ts: Define dynamic setting defaults using runtime context with functions in settings configuration
Use defaultsByInstallVersion property for gradual feature rollout based on version in settings configuration

Files:

src/composables/useFeatureFlags.ts
src/platform/remoteConfig/types.ts

src/**/{services,composables}/**/*.{ts,tsx}