Skip to content

Conversation

@huchenlei
Copy link
Contributor

@huchenlei huchenlei commented Mar 20, 2025

RFC: Comfy-Org/rfcs#6

This PR:

  • Removes legacy Reroute node
  • Automatically convert all legacy reroute nodes in workflow to new native reroute when the workflow loads

image
will be automatically convert to
image

Limitations:

  • All floating (not fully connected) reroutes will be lost in current conversion logic. We can further improve this to add corresponding floating link data.

┆Issue is synchronized with this Notion page by Unito

@huchenlei huchenlei requested review from a team as code owners March 20, 2025 00:04
@huchenlei huchenlei marked this pull request as draft March 20, 2025 00:05
@huchenlei huchenlei added the New Browser Test Expectations New browser test screenshot should be set by github action label Mar 20, 2025
@huchenlei
Copy link
Contributor Author

@webfiltered
Copy link
Contributor

Should now be unblocked.

@huchenlei huchenlei marked this pull request as ready for review March 22, 2025 22:39
@huchenlei huchenlei added New Browser Test Expectations New browser test screenshot should be set by github action and removed New Browser Test Expectations New browser test screenshot should be set by github action labels Mar 22, 2025
@huchenlei huchenlei added New Browser Test Expectations New browser test screenshot should be set by github action and removed New Browser Test Expectations New browser test screenshot should be set by github action labels Mar 22, 2025
@huchenlei huchenlei merged commit 564c4d5 into main Mar 22, 2025
2 checks passed
@huchenlei huchenlei deleted the reroute_migration branch March 22, 2025 22:56
huchenlei pushed a commit that referenced this pull request Mar 31, 2025
huchenlei added a commit that referenced this pull request Mar 31, 2025
christian-byrne pushed a commit that referenced this pull request May 20, 2025
christian-byrne pushed a commit that referenced this pull request May 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

New Browser Test Expectations New browser test screenshot should be set by github action

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants