CU-8699vnuwf Ignore hidden files when loading model packs #54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…idden file/folders
mart-r
added a commit
that referenced
this pull request
Jul 18, 2025
* CU-8699vnuwf: Ignore hidden files/folders when loading model pack * CU-8699vnuwf: Add a test to make sure model pack can be loaded with hidden file/folders
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During model pack load, all folders are attempted to be deserialised.
However, if there's hidden / unexpected files, those could mess things up because they're not in the expected format.
This PR will fix the above by ignoring hidden (
.-prefixed) folders when loading model packs.The test added failed without this change.
The change itself was pretty trivial.