Skip to content

CU-8699py5m0 Multiprocessing issues #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 7, 2025
Merged

CU-8699py5m0 Multiprocessing issues #34

merged 4 commits into from
Jul 7, 2025

Conversation

mart-r
Copy link
Collaborator

@mart-r mart-r commented Jul 7, 2025 •
edited
Loading

Fix some multiprocessing issues.

The things I've noticed / fixed:

  • When batching based on the number of characters the order of the index and text was getting mixed up
  • When using Addons (e.g MetaCAT) in a multiprocessed way the addon data paths weren't set
    • Because it is done on init and depends on the tokenizer
    • And because of how the data is pickled for multiprocessing, this is omitted

This PR attempts to fix both issues.

@mart-r mart-r merged commit 01ad04c into main Jul 7, 2025
13 checks passed
@mart-r mart-r deleted the CU-8699py5m0-multiprocessing-issues branch July 7, 2025 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mart-r