CU-8699may9k Allow CDB and Vocab load to convert from legacy #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…able when loading CBD
…able when loading Vocab
Yet still do it centrally
…cy conversion disabled
More specifically, loading it as regular ON TOP of doing the conversion
mart-r
changed the title
PS: This shouldn't have passed workflow before, no idea why it did and now doesn't.
mart-r
deleted the
CU-8699may9k-allow-cdb-and-vocab-load-to-convert-from-legacy
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows
CDB.loadand theVocab.loadmethods to convert legacy models on the fly.It also adds a few small tests.
The PR still allows the user to disable this feature by setting
MEDCAT_AVOID_LECACY_CONVERSIONtoTrue.