Skip to content

CU-869a95nu1 Fix spacy model cleanup #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 27, 2025
Merged

CU-869a95nu1 Fix spacy model cleanup #115

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
968f846
CU-869a95nu1: Fix spacy eokznier old path cleanup issue
mart-r Aug 27, 2025
94fe65b
CU-869a95nu1: Simplify spacy model saving somewhat
mart-r Aug 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions medcat-v2/medcat/tokenizing/spacy_impl/tokenizers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,12 +106,9 @@ def save_internals_to(self, folder_path: str) -> str:
folder_path, f"{TOKENIZER_PREFIX}{self._spacy_model_name}")
if os.path.exists(subfolder):
# NOTE: always overwrite
shutil.rmtree(folder_path)
shutil.rmtree(subfolder)
logger.debug("Saving spacy model to '%s'", subfolder)
cur_path = self._nlp._path
if cur_path is None:
raise ValueError(f"Unable to save spacy: {self._nlp}")
shutil.copytree(cur_path, subfolder)
self._nlp.to_disk(subfolder)
return subfolder

def load_internals_from(self, folder_path: str) -> bool:
Expand Down
Loading