CU-869a6v8qd: Fix tutorial links #108
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alhendrickson
approved these changes
Aug 20, 2025
alhendrickson
approved these changes
Aug 20, 2025
medcat-v2-tutorials/README.md
Outdated
| | Part | Title | | ||
| | ---- |-----------------------------------------------------------------------------| | ||
| | 1. | [Migrate a v1 model to v2](https://github.com/CogStack/cogstack-nlp/blob/main/notebooks/introductory/migration/1._Migrate_v1_model_to_v2.ipynb) | | ||
| | 1. | [Migrate a v1 model to v2](https://github.com/CogStack/cogstack-nlp/blob/main/medcat-v2-tutorials/notebooks/introductory/migration/1._Migrate_v1_model_to_v2.ipynb) | |
There was a problem hiding this comment.
Oh I'd mean to ask your opinion on this, super minor.
I'd noticed we can just do relative path for this readme. Do we use this file somewhere else so want the full github url?
Just notebooks/introductory/migration/1._Migrate_v1_model_to_v2.ipynb instead of the github url.
It works in the github UI too
If it's just used here then I'd just go relative path...
There was a problem hiding this comment.
Good point. I think (in the very early days) these might have been on the main MedCAT README. Which meant they propagated to pypi. And my guess is that that's why they've always been a full link rather than a relative one. But I've never questioned it.
Right now, I don't see a reason they need to be github links. Should be finw with relative ones, as far as I know.
mart-r
commented
Aug 20, 2025
medcat-v2-tutorials/README.md
Outdated
| | ---- |-----------------------------------------------------------------------------| | ||
| | 1. | [Creating and using a custom tokenizer](https://github.com/CogStack/cogstack-nlp/blob/main/notebooks/advanced/1._Creating_and_using_a_custom_tokenizer.ipynb) | | ||
| | 2. | [Create and use component](https://github.com/CogStack/cogstack-nlp/blob/main/notebooks/advanced/2._Create_and_use_component.ipynb) | | ||
| | 1. | [Creating and using a custom tokenizer](https://github.com/CogStack/cogstack-nlp/blob/medcat-v2-tutorials/main/notebooks/advanced/1._Creating_and_using_a_custom_tokenizer.ipynb) | |
mart-r
commented
Aug 20, 2025
medcat-v2-tutorials/README.md
Outdated
| | 1. | [Creating and using a custom tokenizer](https://github.com/CogStack/cogstack-nlp/blob/main/notebooks/advanced/1._Creating_and_using_a_custom_tokenizer.ipynb) | | ||
| | 2. | [Create and use component](https://github.com/CogStack/cogstack-nlp/blob/main/notebooks/advanced/2._Create_and_use_component.ipynb) | | ||
| | 1. | [Creating and using a custom tokenizer](https://github.com/CogStack/cogstack-nlp/blob/medcat-v2-tutorials/main/notebooks/advanced/1._Creating_and_using_a_custom_tokenizer.ipynb) | | ||
| | 2. | [Create and use component](https://github.com/CogStack/cogstack-nlp/blob/medcat-v2-tutorials/main/notebooks/advanced/2._Create_and_use_component.ipynb) | |
alhendrickson
approved these changes
Aug 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like the links weren't correct in the README.