Skip to content

feat: add remote host configuration support for Unity WebSocket connection #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 29, 2025

Conversation

ichimi-abunai
Copy link

@ichimi-abunai ichimi-abunai commented Jun 28, 2025

Looking at the existing description, I can see it contains substantial content with clear sections including Summary, Changes, Usage Example, and Testing. This is not empty or a template, so I need to enhance it with additional analysis while preserving the existing structure.

Summary

Enables remote Unity Editor connections across network. Useful for development setups where Unity runs on different machine.

Changes

  • Add configurable host property to McpUnity class
  • Support UNITY_HOST environment variable as first priority
  • Support Host configuration in Unity's McpUnitySettings.json as fallback
  • Update WebSocket URL to use configurable host instead of hardcoded localhost
  • Maintains backward compatibility

Technical Implementation Details

The implementation adds a new host property to the McpUnity class, initialized to 'localhost' by default. The configuration resolution follows a clear priority order:

  1. UNITY_HOST environment variable (highest priority)
  2. Host field in configuration file
  3. Default to 'localhost' (maintains existing behavior)

The WebSocket connection URL construction in the connect() method is updated from the hardcoded ws://localhost:${this.port}/McpUnity to use the configurable ws://${this.host}:${this.port}/McpUnity format.

Usage Example

Remote Unity setup:

# Unity running on 192.168.1.100, launch MCP bridge on different machine
UNITY_HOST=192.168.1.100 node server.js

Or via Unity settings file:

{
  "Host": "192.168.1.100",
  "Port": 8090
}

Default behavior (unchanged):

# Still connects to localhost:8090 if no host specified
node server.js

Testing

Tested with Unity Editor on Windows PC and MCP bridge on remote Ubuntu server. Verified GameObject creation, selection, etc work remotely.

Changes that Break Backward Compatibility

N/A - The implementation maintains full backward compatibility by defaulting to 'localhost' when no host configuration is provided.

Documentation

N/A - No documentation files were modified in this PR, though the usage examples in the description provide clear guidance for the new functionality.

Created with Palmier

…ction

Add configurable host property to McpUnity class with support for UNITY_HOST
environment variable and Host configuration in Unity's McpUnitySettings.json.
Maintains full backward compatibility with original Unity workflow while
enabling remote Unity Editor connections across network.
Copy link
Contributor

coderabbitai bot commented Jun 28, 2025

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing Touches
🧪 Generate Unit Tests
  • Create PR with Unit Tests
  • Post Copyable Unit Tests in Comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai auto-generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Owner

@CoderGamester CoderGamester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good suggestion

please add to README documentation in all languages the information for the UNITY_HOST option

Add it into the option section as is structured in the UNITY_PORT description

ichimi abunai added 2 commits June 28, 2025 09:31
- Add AllowRemoteConnections setting to McpUnitySettings
- Update WebSocket server to bind to 0.0.0.0 when remote connections enabled
- Add UI checkbox in Unity Editor window for remote connection toggle
- Server automatically restarts when binding setting changes
- Defaults to localhost-only connections for security
Add documentation for UNITY_HOST environment variable and Unity Editor
remote connection settings to all language READMEs.
@ichimi-abunai
Copy link
Author

Thanks for review. Docs updated.

We also added a checkbox for remote connections in the editor since the WebSocket server was set to listen on localhost only. The checkbox toggles between localhost (default) and 0.0.0.0 in order to allow remote connections.

image

Tooltip:
image

Copy link
Owner

@CoderGamester CoderGamester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great addition to add option in the settings
Thank you

@CoderGamester CoderGamester merged commit 17d1fca into CoderGamester:main Jun 29, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants