Skip to content

Conversation

@uaoleg
Copy link
Contributor

@uaoleg uaoleg commented Jan 8, 2023

No description provided.

@SamMousa
Copy link
Collaborator

SamMousa commented Jan 8, 2023

Why not fix the type on the assign? Now it is done twice

@uaoleg
Copy link
Contributor Author

uaoleg commented Jan 8, 2023

Why not fix the type on the assign? Now it is done twice

Because after assign we have criterias like $queryString === null

Copy link
Member

@Arhell Arhell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@samdark samdark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK.

@uaoleg
Copy link
Contributor Author

uaoleg commented Jan 14, 2023

@SamMousa @Arhell can we merge it please?

@SamMousa SamMousa merged commit 8524425 into Codeception:master Jan 14, 2023
@uaoleg uaoleg deleted the patch-1 branch January 14, 2023 12:12
@acorncom
Copy link

Is there someone who can release this? Not urgent, but it's throwing a few wrinkles in a PHP 8.1 upgrade on our end 😄

@acorncom
Copy link

acorncom commented Jun 6, 2023

For future travelers, this was released in 1.1.8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants