Codeception documentation specified this is true

[SaloEater]

https://codeception.com/docs/modules/Yii2
transaction - (default: true)

[SamMousa]

LGTM

[SamMousa]

Thanks!

[Naktibalda]

I wonder if it had to be a documentation fix instead, this is a breaking change for some users.

#14

[SamMousa]

In hindsight you are 100% right.

[SaloEater]

I wonder if it had to be a documentation fix instead, this is a breaking change for some users.

#14

To be honest, if someone writes non-transactional test then he almost 100% has errors in his code.

[SamMousa]

No that's not true. It might not be independent and well structured, but it is no indicator for errors...

[Naktibalda]

@SamMousa It isn't too late to change default value to false and document it.

[SamMousa]

That's true, also fine with me.

[Naktibalda]

I looked at the code and there was code which set transaction to the same value as cleanup if transaction wasn't set, and cleanup is set to true by default, so this change only made difference for users who had cleanup: false and no transaction setting in their configuration.

module-yii2/src/Codeception/Module/Yii2.php

Lines 229 to 230 in 1802a03

	if ($this->config['transaction'] === null) {
	$this->config['transaction'] = $this->backupConfig['transaction'] = $this->config['cleanup'];