Skip to content

Code standards updated to PHP 7.2 #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 18, 2021
Merged

Code standards updated to PHP 7.2 #14

merged 1 commit into from
May 18, 2021

Conversation

@TavoNiievez
Copy link
Member

@TavoNiievez TavoNiievez commented May 9, 2021

  • Added strict types
  • Added return types
  • Added some typehints
  • Removed unnecessary qualifiers
  • sha1 by default instead of md5.

@TavoNiievez TavoNiievez requested a review from Jeckerson May 9, 2021 20:13
@TavoNiievez TavoNiievez marked this pull request as ready for review May 13, 2021 02:40
@TavoNiievez TavoNiievez requested a review from Naktibalda May 13, 2021 02:40
@Jeckerson Jeckerson merged commit 8f2bc9d into Codeception:master May 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Naktibalda Naktibalda Naktibalda approved these changes

@Jeckerson Jeckerson Jeckerson approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@TavoNiievez @Naktibalda @Jeckerson