Fix not primary auto_increment case #21
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The assumption that auto_increment is always the value for primary key is wrong. As example: * there is a table user, where primary id is - userId which is a md5 random string. * Autoincrement is on the userNumber field, which is not primary, but by some reason it is there. Now we add a user with haveInDatabase, and with specific id:['userId'=>'special'], what will endup in insertedRows? usesrId => 10 for example, as insertId for user was 10, and sure, it will not be cleaned up.
Member
|
Thanks for this contribution, but please create tests for the issue your change fixes. We have a few test cases for primary key logic in https://github.com/Codeception/module-db/blob/master/tests/unit/Codeception/Module/Db/TestsForDb.php |
Member
|
Replaced by #44 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The assumption that auto_increment is always the value for primary key is wrong.
As example:
Now we add a user with haveInDatabase, and with specific id:['userId'=>'special']; what will endup in insertedRows? usesrId => 10 but should be userId=>'special'. As insertId for user was 10, and sure, it will not be cleaned up.