Fix layout for default github avatars in changelog #900
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "s" query parameter appended to the github avatar url is ignored for default github avatars.
W0rma
commented
Dec 23, 2025
| $changelog .= sprintf("\n\n### %s %s: %s\n\n", $repo, $release['tag_name'], $release['name']); | ||
|
|
||
| $changelog .= sprintf("Released by [ %s](%s) on %s", | ||
| $changelog .= sprintf('Released by [{:height="16" width="16"} %s](%s) on %s', |
Contributor
Author
There was a problem hiding this comment.
I got the syntax from https://kramdown.gettalong.org/syntax.html#images
Since additional attributes can be added via span and block IALs, it is possible, for example, to specify image width and height:
Here is an inline {:height="36px" width="36px"}.
Contributor
Author
|
@TavoNiievez FYI |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that some github avatars are not properly formatted in https://codeception.com/changelog:
Seems like the layout is only broken for github users which have default avatar.
The layout looks fine for users which have their own avatar:
RobotFile.phpuses the avatar url returned by github and appends thes=16query parameter to make sure that the size of the image is16.However, the "s" query parameter seems to be ignored for default github avatars (see f.e. https://stackoverflow.com/questions/22932422/get-github-avatar-from-email-or-name#comment118252343_36380674).