Skip to content

Conversation

not-a-ethan
Copy link
Contributor

@not-a-ethan not-a-ethan commented Mar 16, 2022

Description

Changed the link to the CC forums to the link to the CC get help subcategory.

Type of Change

  • Editing an existing entry (fixing a typo, bug, issues, etc)

Checklist

  • All writings are my own.
  • My entry follows the Codecademy Docs style guide.
  • My changes generate no new warnings.
  • I have performed a self-review of my own writing and code.
  • I have checked my entry and corrected any misspellings.
  • I have made corresponding changes to the documentation if needed.
  • I have confirmed my changes are not being pushed from my forked main branch.
  • I have confirmed that I'm pushing from a new branch named after the changes I'm making.
  • Under "Development" on the right, I have linked any issues that are relevant to this PR (write "Closes # in the "Description" above).

@not-a-ethan not-a-ethan marked this pull request as ready for review March 16, 2022 01:33
@Dusch4593 Dusch4593 added documentation Improvements or additions to documentation enhancement New feature or request labels Mar 16, 2022
@not-a-ethan
Copy link
Contributor Author

We should probably close #621 when this is merged. And you cant link discussions.

@Dusch4593
Copy link
Contributor

Dusch4593 commented Mar 16, 2022

We should probably close #621 when this is merged. And you cant link discussions.

I'm not too familiar with GH discussions. It would be good probably, for now, to keep for archival purposes?

cc: @sonnynomnom

@Dusch4593
Copy link
Contributor

Also, since this one has to do with editing documentation, let's bring in @sonnynomnom and @yangc95 for review and feedback. 😄

@not-a-ethan
Copy link
Contributor Author

not-a-ethan commented Mar 16, 2022

@Dusch4593 locking a discussion makes it so only maintainers can replay but everybody can still view it. And it can be unlocked again. Heres is the help article on locking them: https://docs.github.com/en/communities/moderating-comments-and-conversations/locking-conversations

@yangc95
Copy link
Contributor

yangc95 commented Mar 18, 2022

@ethan-master-coding Cool idea! I was wondering if we can even create a new topic in Community Forum @sonnynomnom 🤔

@not-a-ethan
Copy link
Contributor Author

not-a-ethan commented Mar 18, 2022

@yangc95 topic or category? A topic is a thread and a category well the name speaks for itself. And it would probably go in #get help because well the category would probably be for getting help.

@yangc95
Copy link
Contributor

yangc95 commented Mar 18, 2022

Community Forum

I see why you linked to the "Codecademy" (meta convos) category now.

I'm concerned with discussions around Docs getting lost among the general meta convos, so maybe we can create a new category in Get Help.

@not-a-ethan
Copy link
Contributor Author

not-a-ethan commented Mar 18, 2022

@yangc95 Ok. So best case scenario we have a new subcategory in #get help.

@not-a-ethan
Copy link
Contributor Author

About possibly adding a subcategory for the docs Mabey we should add badges for # of contributions to the docs with the GH plugin.

@not-a-ethan not-a-ethan mentioned this pull request Mar 20, 2022
3 tasks
@yangc95
Copy link
Contributor

yangc95 commented Mar 20, 2022

@yangc95 Ok. So best case scenario we have a new subcategory in #get help.

The best-case scenario is to get a new subcategory. But revisiting the Forum and looking at the description for "Get Help" vs "Community," I can't help but think Docs should go in Community:

Screen Shot 2022-03-19 at 11 19 38 PM

Let me first see if getting a category added is possible 👍

@not-a-ethan
Copy link
Contributor Author

@sonnynomnom Guessing you accidentally missed this notification. Mind giving your input when you have some time.

@not-a-ethan
Copy link
Contributor Author

@Dusch4593 @yangc95 If we do get a category to think we should copy and paste the contribution guide and some other things to try and prevent a lot of questions like How do I contribute? and other questions of that nature that are answered by these files already?

Co-authored-by: Christine Yang <[email protected]>
@not-a-ethan
Copy link
Contributor Author

not-a-ethan commented Apr 7, 2022

Mabey we should add badges for # of contributions to the docs with the GH plugin.

Think we should do this? And should we make the description the read me:
image

And we can now merge this right?

@yangc95
Copy link
Contributor

yangc95 commented Apr 7, 2022

And we can now merge this right?

I think this description looks great for now! I'll approve of this PR 🚀 Currently, we're adding some new topics to the category for some more talking points/structure, ideas are welcome!

Copy link
Contributor

@Dusch4593 Dusch4593 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as well! 👍🏻

@yangc95 yangc95 merged commit 696ee67 into Codecademy:main Apr 7, 2022
@not-a-ethan not-a-ethan deleted the README-update branch April 7, 2022 17:03
@not-a-ethan
Copy link
Contributor Author

@Dusch4593 @yangc95 think we should add some tips for new contributors to the post? Like, take on an issue for your first contribution and stuff like that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants