Updating branch with master repo updates #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WebGL backend is supposed to support 5D or 6D inputs for gatherND op. However, WebGL backend throws an error for such inputs because of the following codes in gatherND. Take an input tensor with (1,48,48,17,2) shape for example:
ivec5 paramsShape = ivec5(1,48,48,17,2);
...
paramsShape[j];
This is problematic because ivec5 is a strcuture defined by us, which could be accessed through [] and could be accessed only through .x/.y/.z/.w/.u.
This PR fixes this problem by applying paramsShape's value directly into the code, instead of using an intermediate ivec5.
Add a new test //tfjs-tflite/src/worker_test to test running tflite in a webworker. The test runs a simple model that just adds the two inputs together.
* Rescaling Preprocessing Layer Co-authored-by: David Kim (@koyykdy) <[email protected]> Brian Zheng (@Brianzheng123) <[email protected]> * PR issues resolved * linting and PR issues resolved Co-authored-by: Adam Lang (@AdamLang96) <[email protected]> Co-authored-by: (@Brianzheng123) <[email protected]> Co-authored-by: David Don Young Kim <[email protected]> Co-authored-by: David Don Young Kim <[email protected]>
Prevent the webgl1 test env from being used in tfjs-layers unless it is explicitly requested (such as by running //tfjs-layers:tfjs-layers_webgl1_test).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.