Skip to content

Resizing layer unit test assertion argument casting error refactored #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dydavidkim merged 9 commits into from
Oct 7, 2022
Merged

Resizing layer unit test assertion argument casting error refactored #57

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
60343aa
Implementation of preprocessing image resizing layer
dydavidkim Sep 29, 2022
02df8cd
Updating image preprocessing test file to include approved usage of C…
dydavidkim Sep 29, 2022
28ace0a
refactored interpolation type declaration
dydavidkim Oct 6, 2022
bde6fa1
Merge branch 'resizing' into resizing
dydavidkim Oct 6, 2022
e1f4825
minor spacing correction
dydavidkim Oct 6, 2022
3d7563c
Merge branch 'resizing' of https://github.com/koyykdy/tfjs into resizing
dydavidkim Oct 6, 2022
b2ee249
Merge branch 'resizing' into resizing
dydavidkim Oct 6, 2022
abe4652
resizing layer test assertion statement argument casting refactored
dydavidkim Oct 7, 2022
09cdbc9
Merge branch 'resizing' of https://github.com/koyykdy/tfjs into resizing
dydavidkim Oct 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tfjs-layers/src/layers/preprocessing/image_resizing.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ export declare interface ResizingArgs extends LayerArgs {
height: number;
width: number;
interpolation?: InterpolationType; // default = 'bilinear';
cropToAspectRatio?: boolean; // default = false;
cropToAspectRatio?: boolean; // default = false;
}

/**
Expand Down
4 changes: 2 additions & 2 deletions tfjs-layers/src/layers/preprocessing/image_resizing_test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ import {image, Rank, Tensor, tensor, zeros, range, reshape} from '@tensorflow/tf
// import {Shape} from '../../keras_format/common';
import {describeMathCPUAndGPU, expectTensorsClose} from '../../utils/test_utils';

import {Resizing} from './image_resizing';
import {Resizing, ResizingArgs} from './image_resizing';

describeMathCPUAndGPU('Resizing Layer', () => {
it('Check if output shape matches specifications', () => {
Expand Down Expand Up @@ -110,7 +110,7 @@ describeMathCPUAndGPU('Resizing Layer', () => {
const incorrectArgs = {height, width, interpolation};
const expectedError =
`Invalid interpolation parameter: ${interpolation} is not implemented`;
expect(() => new Resizing(incorrectArgs)).toThrowError(expectedError);
expect(() => new Resizing(incorrectArgs as ResizingArgs)).toThrowError(expectedError);
});

it('Config holds correct name', () => {
Expand Down